Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

howto: Add VMCache introduction and guide #393

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

teawater
Copy link
Member

@teawater teawater commented Mar 7, 2019

Add "What Is VMCache and How To Enable It" to howto.

Fixes: #392

Signed-off-by: Hui Zhu [email protected]

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teawater - thanks for raising!

First pass review comments...

how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
@teawater teawater requested a review from a team as a code owner March 10, 2019 03:04
@teawater teawater force-pushed the vmcache branch 2 times, most recently from 74d601b to e9a605d Compare March 10, 2019 03:55
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teawater!

lgtm

Ping @kata-containers/documentation.

Copy link

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. I have a few comments regarding wording. Also, please merge everything in a single commit.

how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
how-to/what-is-vm-cache-and-how-do-I-use-it.md Outdated Show resolved Hide resolved
Add "What Is VMCache and How To Enable It" to howto.

Fixes: kata-containers#392

Signed-off-by: Hui Zhu <[email protected]>
@sboeuf
Copy link

sboeuf commented Mar 12, 2019

/test

@gnawux
Copy link
Member

gnawux commented Mar 12, 2019

nice document

@gnawux gnawux merged commit 419d979 into kata-containers:master Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants