This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 304
howto: Add VMCache introduction and guide #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
reviewed
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @teawater - thanks for raising!
First pass review comments...
teawater
force-pushed
the
vmcache
branch
2 times, most recently
from
March 10, 2019 03:55
74d601b
to
e9a605d
Compare
jodh-intel
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sboeuf
reviewed
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. I have a few comments regarding wording. Also, please merge everything in a single commit.
Add "What Is VMCache and How To Enable It" to howto. Fixes: kata-containers#392 Signed-off-by: Hui Zhu <[email protected]>
sboeuf
approved these changes
Mar 12, 2019
/test |
nice document |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "What Is VMCache and How To Enable It" to howto.
Fixes: #392
Signed-off-by: Hui Zhu [email protected]