Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Limitations: add selinux support limitation #253

Merged

Conversation

grahamwhaley
Copy link
Contributor

We do not currently support enablement of selinux in the
dockerd config. Document that.

Fixes: #252

Signed-off-by: Graham Whaley [email protected]

@nitkon
Copy link
Contributor

nitkon commented Sep 25, 2018

LGTM

@jodh-intel
Copy link
Contributor

I appreciate you're documenting the docker server side, but is this all essentially the same as the following?:

That section doesn't spell it all out (as we don't want to have to enumerate all the security types which may change), but we don't support --security-opt label:$selinux_context.

@grahamwhaley
Copy link
Contributor Author

Ah, so that is the link to how/where it gets passed into the runtime @jodh-intel - how about I add a ref in my new section over to that --security-opt one?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ref section idea sounds good to me.

@jodh-intel
Copy link
Contributor

@grahamwhaley - yep, that plan sounds good to me.

@amshinde
Copy link
Member

@grahamwhaley k8s also has selinux labels: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#assign-selinux-labels-to-a-container
We should mention that as well for completeness.

We do not currently support enablement of `selinux` in the
dockerd config. Document that.

Fixes: kata-containers#252

Signed-off-by: Graham Whaley <[email protected]>
@grahamwhaley grahamwhaley force-pushed the 20180925_selinux_limitation branch from e465f82 to 38a06ca Compare October 1, 2018 15:31
@grahamwhaley
Copy link
Contributor Author

OK, I've added a link to the other section to ref the non-working security option, and also a link out to the k8s selinux label page. @jodh-intel @amshinde ptal.

@jodh-intel
Copy link
Contributor

jodh-intel commented Oct 1, 2018

lgtm

Approved with PullApprove Approved with PullApprove

Copy link
Member

@amshinde amshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Contributor Author

afaik, this is done. In theory, needs one more ack from @kata-containers/documentation , but, it seems pullapprove may not have registered @jodh-intel ack. I'm OK with somebody pushing this through if they want.

@GabyCT
Copy link
Collaborator

GabyCT commented Oct 4, 2018

lgtm

Approved with PullApprove Approved with PullApprove

@GabyCT GabyCT merged commit 07af37e into kata-containers:master Oct 4, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants