Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Limitation: Document docker --security-opt option not supported #242

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

nitkon
Copy link
Contributor

@nitkon nitkon commented Sep 6, 2018

Fixes: #241

Signed-off-by: Nitesh Konkar [email protected]

@jodh-intel
Copy link
Contributor

Thanks @nitkon!

lgtm

@jcvenegas
Copy link
Member

lgtm

@jcvenegas
Copy link
Member

ping @kata-containers/documentation

@caoruidong
Copy link
Member

caoruidong commented Sep 7, 2018

lgtm.
Is this to say we don't support all --security-opt like apparmor as well?

Approved with PullApprove Approved with PullApprove

@jodh-intel
Copy link
Contributor

Good point @caoruidong!

@nitkon - could you reword this change slightly because although we don't support the following security options (yet):

... we do support:

  • --security-opt="no-new-privileges:...

Hence, it might be best to say we only partially support --security-opt currently.

@nitkon
Copy link
Contributor Author

nitkon commented Sep 7, 2018

@jcvenegas @jodh-intel : Updated my PR.

@jodh-intel
Copy link
Contributor

jodh-intel commented Sep 7, 2018

lgtm.

@klynnrif - ptal.

Approved with PullApprove Approved with PullApprove

@gnawux
Copy link
Member

gnawux commented Sep 12, 2018

looks good, and it is not a big patch.

let's merge it.

@gnawux gnawux merged commit ac8f668 into kata-containers:master Sep 12, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
build and install kata containers components from master and
run osbuilder tests.

fixes kata-containers#242

Signed-off-by: Julio Montes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants