Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: use peak in max_usage_in_bytes #126

Merged
merged 1 commit into from
Oct 23, 2023
Merged

memory: use peak in max_usage_in_bytes #126

merged 1 commit into from
Oct 23, 2023

Conversation

HeRaNO
Copy link

@HeRaNO HeRaNO commented Sep 11, 2023

Kernel 5.19 introduces memory.peak and kernel 6.5 introduces memory.swap.peak to expose the memory and swap usage watermark. This change use these values to fill max_usage_in_bytes.

@HeRaNO
Copy link
Author

HeRaNO commented Sep 11, 2023

I opened a new pr for my misoperation, the old one is closed. Pls re-approve this. Sorry for the inconvenience @liubin
@Tim-Zhang pls take a review, thanks.

@liubin
Copy link
Member

liubin commented Sep 12, 2023

@HeRaNO thank you, can you fix your commit message?

Kernel 5.19 introduces `memory.peak` and kernel 6.5 introduces
`memory.swap.peak` to expose the memory and swap usage watermark.
This change use these values to fill `max_usage_in_bytes`.

Signed-off-by: HeRaNO <[email protected]>
@HeRaNO
Copy link
Author

HeRaNO commented Sep 12, 2023

@HeRaNO thank you, can you fix your commit message?

fixed.

@HeRaNO
Copy link
Author

HeRaNO commented Sep 25, 2023

@Tim-Zhang ping

@HeRaNO
Copy link
Author

HeRaNO commented Oct 22, 2023

Anyone take a look? It has been last for about 1 month. T T

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @HeRaNO

@Tim-Zhang Tim-Zhang merged commit 01885ad into kata-containers:main Oct 23, 2023
Tim-Zhang added a commit to Tim-Zhang/cgroups-rs that referenced this pull request Oct 25, 2023
@Tim-Zhang Tim-Zhang mentioned this pull request Oct 25, 2023
Tim-Zhang added a commit to Tim-Zhang/cgroups-rs that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants