Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.0 Port for Issue 63 (https://github.com/kasketis/netfox/issue… #67

Closed
wants to merge 2 commits into from

Conversation

jmurff
Copy link

@jmurff jmurff commented Jun 26, 2016

  • Port to Swift 3.0
  • Added ability to use Button to display NFX
  • Updated Workaround.md to point at my AFNetwork 3.0 (Objective C) fix for missing HTTP Bodies(No HTTP body for requests #16) See this: GIST

@jmurff jmurff mentioned this pull request Jun 26, 2016
Copy link
Owner

@kasketis kasketis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your pull request. Unfortunately it has some conflicts. In order to merge it can you please solve them?

@jmurff
Copy link
Author

jmurff commented Sep 15, 2016

I have had to port it at least 3 more times with every new xcode beta.
I can submit a final if you like. I also added another feature allowing
the saving and emailing of the full http sessions in one.

@jmurff
Copy link
Author

jmurff commented Sep 15, 2016

I never used the OSX stuff that was added and it was added after I had the library and needed to port. The swift code for iOS is all working and ported. Feel free to use it or not.

@kasketis kasketis closed this Nov 11, 2016
@kasketis
Copy link
Owner

Thanks! Merged to Swift 3 https://github.com/kasketis/netfox/tree/swift3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants