Workaround for issue #16 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e body data.
This is to work around a problem where by the time NSURLProtocol.startLoading is called, the HTTPBody of the request and canonical request will both be nil
If you don't set the NFXBodyData property then it will be ignored and defaulted to the original behaviour of returning NSData()
If you want to log request data you should do something like the following:
if let bodyData = mutableURLRequest.HTTPBody {
NSURLProtocol.setProperty(bodyData, forKey: "NFXBodyData", inRequest: mutableURLRequest)
}
Wherever you construct your NSMutableURLRequest's (for instance when using Alamofire - in URLRequest of URLRequestConvertible)
See: http://openradar.appspot.com/15993891
jasoncabot
changed the title
|
Awesome work mate! I will add this workaround in the readme file 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFXBody will now check the NSURLProtocol for if a value is set for the body data.
This is to work around a problem where by the time NSURLProtocol.startLoading is called, the HTTPBody of the request and canonical request will both be nil
If you don't set the NFXBodyData property then it will be ignored and defaulted to the original behaviour of returning NSData()
If you want to log request data you should do something like the following:
Wherever you construct your NSMutableURLRequest's (for instance when using Alamofire - in URLRequest of URLRequestConvertible)
See: http://openradar.appspot.com/15993891