Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift+esc can be mapped to ctrl+j #40

Closed
thekalinga opened this issue Nov 29, 2016 · 5 comments
Closed

shift+esc can be mapped to ctrl+j #40

thekalinga opened this issue Nov 29, 2016 · 5 comments
Assignees
@kasecato
Labels
enhancement
Milestone
v0.2.5

Comments

@thekalinga
Copy link

shift+esc to hide panel can be mapped to ctrl+j which maps to hide panel action in vscode
@kasecato kasecato self-assigned this Nov 29, 2016
@kasecato kasecato added this to the v0.2.4 milestone Nov 29, 2016
kasecato pushed a commit that referenced this issue Nov 30, 2016
Fixed shift+esc can be mapped to ctrl+j #40
4f9f7eb
kasecato pushed a commit that referenced this issue Nov 30, 2016
Fixed shift+esc can be mapped to ctrl+j #40 (#42)
8d979fe
@thekalinga
Copy link
Author

thekalinga commented Nov 30, 2016 •
edited
Loading

The fix you gave is not hiding the panel instead hiding last opened editor.

To test why it is not working, open an embedded terminal & press shift+esc. You will notice that it is not hiding.

shift+esc should map to close panel action, not active or last active window

@kasecato kasecato reopened this Nov 30, 2016
@kasecato kasecato modified the milestones: v0.2.5, v0.2.4 Nov 30, 2016
kasecato pushed a commit that referenced this issue Dec 1, 2016
fixed shift+esc can be mapped to ctrl+j #40
618f9ed
kasecato pushed a commit that referenced this issue Dec 1, 2016
fixed shift+esc can be mapped to ctrl+j #40
fea7745
kasecato pushed a commit that referenced this issue Dec 1, 2016
fixed shift+esc can be mapped to ctrl+j #40 (#45)
2a5c533 
* fixed shift+esc can be mapped to ctrl+j #40

* fixed shift+esc can be mapped to ctrl+j #40
@kasecato
Copy link
Owner

kasecato commented Dec 1, 2016 •
edited
Loading

@thekalinga

@thekalinga
Copy link
Author

I just verified for terminal, shift+esc is not working for terminal.

Version info

Version 1.8.0-insider
Commit be33bcdb2beb2d01c76ec8f830a70feaaa6721f5
Date 2016-12-01T09:40:51.017Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
IDEA Plugin version: 0.2.5

@thekalinga
Copy link
Author

thekalinga commented Dec 1, 2016 •
edited
Loading

N/A output, cause No workbench action to hide panel #14779

This is not valid anymore as you have close panel action in vscode.

So we should be able to map vscode to IDEA shortcuts exactly

@thekalinga
Copy link
Author

shift+esc is not working for problems/errors view aswell

kasecato pushed a commit that referenced this issue Jan 12, 2017
fixed #40
d3020d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasecato kasecato

Labels
enhancement
Projects
None yet
Milestone
v0.2.5
Development

No branches or pull requests
2 participants
@thekalinga @kasecato