-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trait revision part 1: #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove find_id parameter of #[widget] implementation attr
IIRC this was added to avoid panic when drawing text whose layout was not set. Should not be required now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kas::event::Handler
methods intoWidget
; removeHandler
traitkas::WidgetConfig
methods intoWidget
; removeWidgetConfig
trait#[widget]
attribute intoWidget
implementation and to override methods generated byderive
Layout
methods toWidget
trait:translation
,spatial_nav
,find_id
List::size_solved
flag: do not inhibit drawing between adding new widgets and callingset_rect
DrawMgr::with_clip_region
andwith_overlay
: change closure type toFnOnce
WidgetId
field toDrawMgr
; remove parameter fromComponent::draw
Layout::layout
(method is to be removed in the future)Revision of the
Layout
trait is cut short here, but this PR is already large enough.