-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventMgr, SetRectMgr, DrawMgr; misc #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: fix bug in MatrixData::update impl for SharedRc<_>
This fixes lag when scrolling data-list-view by click on the scrollbar with a large number of entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manager
->EventMgr
,ManagerState
->EventState
fn WidgetCore::identify(&self)
returning a printable object (e.g.Canvas#0
)fn WidgetChildren::is_strict_ancestor_of(&self, id: &WidgetId)
Layout::size_rules
now takessize_mgr: SizeMgr
parameter (new type wrappingSizeHandle
)Layout::set_rect
now takesmgr: &mut SetRectMgr
parameter (new type, able to constructSizeMgr
and acceptTkAction
, constructible fromEventMgr
)Layout::draw
now takes parameterdraw: DrawMgr
(new type, able to constructSizeMgr
,SetRectMgr
andEventState
kas_core::draw::handle
andkas_core::draw::theme
private modules to newkas_core::theme
moduleWidgetCore::input_state
withEventMgr::draw_state
Quad::with_coords
andwith_pos_and_size
toQuad::from_coords
andfrom_pos_and_size
DragHandle
is now never keyboard-navigable (simpler logic)#[must_use]