Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvApprox/CastApprox; tuple + array support; doc #21

Merged
merged 17 commits into from
Feb 15, 2022
Merged

ConvApprox/CastApprox; tuple + array support; doc #21

merged 17 commits into from
Feb 15, 2022

Conversation

dhardy
Copy link
Contributor

@dhardy dhardy commented Feb 15, 2022

This will likely be released as 0.5:

  • conv methods now have default implementations over try_conv methods to ease third-party implementations
  • Add ConvApprox and CastApprox for approximate conversions without specific rounding; implement for f64 -> f32
  • ConvApprox<T> is auto-implemented over Conv<T>
  • Support arrays and tuples for Conv and ConvFloat (and therefore Cast and CastFloat); closes Extend to other types: NonZero*, tuples, arrays, ...? #19
  • Update documentation
  • MSRV is now 1.53.0

Limitations due to lack of specialization (or other conflicting-trait-impl resolution):

  • impl<T> Conv<T> for T was removed
  • we cannot implement array/tuple support for ConvApprox
  • we cannot auto-implement ConvApprox<T> over ConvFloat<T>

Limitation due to unsized-type support:

  • array implementations require T: Copy + Default and may not be optimal

Limitations due to code size:

  • Conv supports 0-6 element tuples
  • ConvFloat only supports 2-tuples

dhardy added 17 commits February 14, 2022 16:05
@dhardy
Improve Conv/Cast doc; default impl for Conv::conv
4850316
@dhardy
Breaking: remove Conv<T> for T impl
0286e21
@dhardy
MSRV=1.53; impl Conv<[S; N]> for [T; N] where T: Conv<S> + Default
422a8b2
@dhardy
Support Conv for tuples (up to 6 arguments)
1c4acd3
@dhardy
Update ConvFloat/CastFloat doc and add default impls to ConvFloat::co…
0fb99ba 
…nv_*
@dhardy
Add ConvApprox and implement f64 to f32 conversion
e34b8af
@dhardy
Tests: add expected panic messages
dae8c80
@dhardy
Add CastApprox; ConvApprox doc and impl for all ConvFloat
81cc3ae
@dhardy
Revise library doc
f614f1b
@dhardy
Implement ConvApprox for all Conv and ConvFloat impls
7712c07
@dhardy
Fixes for no_std
bb2b64f
@dhardy
Doc: specify that ConvApprox usually truncates
9350096
@dhardy
Array/tuple impls: directly implement conv method
6f1571a
@dhardy
Implement ConvFloat for arrays and 2-tuples
24814e1
@dhardy
Update CHANGELOG and README
1b0a877
@dhardy
README: add performance section
0ba4e0c
@dhardy
Fix no_std
dc2c6e2
@dhardy dhardy merged commit f08180a into master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend to other types: NonZero*, tuples, arrays, ...?
1 participant
@dhardy