Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB name with hyphen and also add env for logging #495

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

NyakudyaA
Copy link
Collaborator

Fixes #494

Also adds an env variable logging to control all the logging params done in #492

@NyakudyaA
Copy link
Collaborator Author

@FunkyPantsSa I added an env variable LOGGING='FALSE' which will need to be set before setting those env variables you defined in the PR, Tested it and it adds a lot of noise to the logs

After your PR merges

Screenshot 2024-12-17 at 15 33 08

With this PR and before

Screenshot 2024-12-17 at 15 33 41

So I assume the defaults values are not optimal or should be set be user

@FunkyPantsSa
Copy link
Contributor

I noticed.

It outputs more detailed logs, such as login, ddl

image image

I think it is the setting of some log environment variables that causes it to output more detailed logs.
adds an env variable logging to control all the logging params is a good idea.
thank u so much

@NyakudyaA NyakudyaA merged commit 2d25521 into develop Dec 17, 2024
11 checks passed
@NyakudyaA NyakudyaA deleted the db-start branch December 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when POSTGRES_DBNAME is not a valid environmental variable.
2 participants