dockerctl: use 'podman' if present and 'docker version' fails #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`podman` is an almost-CLI-compatible replacement for `docker`, which
allows unprivileged users to run containers, with no daemon. On some
systems, `docker` is a symbolic link to `podman`.
I say "almost" because one command that is not compatible is `docker
version --format '{{ json . }}'`, used by Karton to detect whether
docker is present and usable.
containers/podman#2671
To work around this, if _try_docker() fails, but running `podman
version` succeeds, use `podman` instead. Otherwise, behave as before.
wjt
force-pushed
the
use-podman-if-docker-fails
branch
from
0771135 to
23c5a9c
Compare
|
Updated to fix some warnings caught by a linter . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podmanis an almost-CLI-compatible replacement fordocker, whichallows unprivileged users to run containers, with no daemon. On some
systems,
dockeris a symbolic link topodman.I say "almost" because one command that is not compatible is
docker version --format '{{ json . }}', used by Karton to detect whetherdocker is present and usable.
containers/podman#2671
To work around this, if _try_docker() fails, but running
podman versionsucceeds, usepodmaninstead. Otherwise, behave as before.