Skip to content

Commit

Permalink
add missing stream arg to is_valid()
Browse files Browse the repository at this point in the history
  • Loading branch information
karthikeyann committed Nov 19, 2021
1 parent 4c5220d commit 2ff7d89
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cpp/src/filling/fill.cu
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ void in_place_fill(cudf::mutable_column_view& destination,
using ScalarType = cudf::scalar_type_t<T>;
auto p_scalar = static_cast<ScalarType const*>(&value);
T fill_value = p_scalar->value(stream);
bool is_valid = p_scalar->is_valid();
bool is_valid = p_scalar->is_valid(stream);
cudf::detail::copy_range(thrust::make_constant_iterator(fill_value),
thrust::make_constant_iterator(is_valid),
destination,
Expand Down
12 changes: 6 additions & 6 deletions cpp/src/search/search.cu
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@ bool contains_scalar_dispatch::operator()<cudf::dictionary32>(column_view const&
// first, find the value in the dictionary's key set
auto index = cudf::dictionary::detail::get_index(dict_col, value, stream);
// if found, check the index is actually in the indices column
return index->is_valid() ? cudf::type_dispatcher(dict_col.indices().type(),
contains_scalar_dispatch{},
dict_col.indices(),
*index,
stream)
: false;
return index->is_valid(stream) ? cudf::type_dispatcher(dict_col.indices().type(),
contains_scalar_dispatch{},
dict_col.indices(),
*index,
stream)
: false;
}

} // namespace
Expand Down

0 comments on commit 2ff7d89

Please sign in to comment.