Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
karthikeyann committed Sep 24, 2024
1 parent be30c60 commit 19f39c2
Show file tree
Hide file tree
Showing 4 changed files with 160 additions and 169 deletions.
12 changes: 6 additions & 6 deletions cpp/include/cudf/io/json.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ class json_reader_options {
/**
* @brief Whether to enable experimental features.
*
* When set to true, new experimental features such new column tree construction
* will be enabled.
* When set to true, experimental features, such as the new column tree construction,
* utf-8 matching of field names will be enabled.
* @return true if experimental features are enabled
*/
[[nodiscard]] bool is_enabled_experimental() const { return _experimental; }
Expand Down Expand Up @@ -467,8 +467,8 @@ class json_reader_options {
/**
* @brief Set whether to enable experimental features.
*
* When set to true, new experimental features such new column tree construction
* will be enabled.
* When set to true, experimental features, such as the new column tree construction,
* utf-8 matching of field names will be enabled.
*
* @param val Boolean value to enable/disable experimental features
*/
Expand Down Expand Up @@ -719,8 +719,8 @@ class json_reader_options_builder {
/**
* @brief Set whether to enable experimental features.
*
* When set to true, new experimental features such new column tree construction
* will be enabled.
* When set to true, experimental features, such as the new column tree construction,
* utf-8 matching of field names will be enabled.
*
* @param val Boolean value to enable/disable experimental features
* @return this for chaining
Expand Down
Loading

0 comments on commit 19f39c2

Please sign in to comment.