[patch] 2024.9.15 #719
Merged
[patch] 2024.9.15 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
danh91
force-pushed
the
patch-2024.9.15
branch
from
45823c9 to
4761609
Compare
|
@danh91 Hello Dan, is there a reason on why this is still not released as a tag ? If you are not planning to release it could you please tell me how to build a tag from it the easiest ? thanks |
|
Hi @vangelow, The release has been created now. |
|
@danh91 Hello |
|
It basically does not add the duties as a part of the request to fedex |
dutiesPayment=lib.identity(
fedex.DutiesPaymentType(
paymentType=provider_units.PaymentType.map(
customs.duty.paid_by
).value,
payor=lib.identity(
fedex.PayorType(
responsibleParty=fedex.ResponsiblePartyType(
address=fedex.AddressType(
streetLines=duty_billing_address.address_lines,
city=duty_billing_address.city,
stateOrProvinceCode=provider_utils.state_code(
duty_billing_address
),
postalCode=duty_billing_address.postal_code,
countryCode=duty_billing_address.country_code,
residential=duty_billing_address.residential,
),
contact=fedex.ResponsiblePartyContactType(
personName=lib.text(
duty_billing_address.contact, max=35
),
emailAddress=duty_billing_address.email,
phoneNumber=duty_billing_address.phone_number,
phoneExtension=None,
companyName=lib.text(
duty_billing_address.company_name,
max=35,
),
faxNumber=None,
),
accountNumber=fedex.AccountNumberType(
value=customs.duty.account_number
),
tins=lib.identity(
fedex.TinType(
number=duty_billing_address.tax_id,
tinType="FEDERAL",
)
if duty_billing_address.has_tax_info
else []
),
)
)
if duty_billing_address.address
else None
),
)
if customs.duty.paid_by != "sender"
and customs.duty.account_number
else NoneThis piece of code should not remove the whole payment, it should just allow to send duties payment of type But skip the payorType and responsibleParty the request can be made with PaymentType as RECIPIENT successfuly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix
fedexpayor info data mapping #718