Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the CI to build different precisions #279

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

Ricardicus
Copy link
Contributor

Adding the BF16, FP16 and FP32 builds to the Github workflow.
I am also passing the defines to the testing and profiling build.

@Ricardicus
Copy link
Contributor Author

Ricardicus commented Apr 28, 2024

It took some attempts before I got it to build... Turns out I needed to raise the cuda image version for the bf16 to compile. Maybe a change in the bf16 api had been introduced.

There is another issue I don't know much about that breaks the build. But I think this PR is kind of solid now.

@karpathy
Copy link
Owner

ok ty, though i'm noticing the CI is failing here? hmm

@Ricardicus
Copy link
Contributor Author

I think you fixed the CI, it was this error:

"
Run OMP_NUM_THREADS=8 ./test_gpt2
Bad version in model file
Error: Process completed with exit code 1.
"

I ran it some time ago, the fix wasn't in back then.

@Ricardicus
Copy link
Contributor Author

Ricardicus commented Apr 28, 2024

Let's see if it builds now.... I pushed and then rebased just to trigger a new build.

@Ricardicus
Copy link
Contributor Author

Looking good 😎

@karpathy karpathy merged commit 18b41b4 into karpathy:master Apr 28, 2024
5 checks passed
@rosslwheeler
Copy link
Contributor

@Ricardicus - this might already be in the code somewhere but when we run - is there a run-time way (a printf?) where we can tell which precision it was built with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants