Windows changes for Makefile #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricardicus
reviewed
Apr 24, 2024
Ricardicus
reviewed
Apr 24, 2024
Ricardicus
reviewed
Apr 24, 2024
|
Since windows is such a world of its own, there will be a question about maintaining it. In order to make it easier during development, should we perhaps introduce a flag to the preprocessor that is only active when building on windows? I can image people writing whole sections of code that is POSIX compliant with zero care in the world for the Windows case. The CI will break and then the question is "can you rewrite" etc.. or "should we stop supporting Windows"? With a flag it is possible to get around it somewhat. You did see a CUDA speed increase on Windows machines? |
Ricardicus
reviewed
Apr 24, 2024
Ricardicus
reviewed
Apr 24, 2024
Ricardicus
reviewed
Apr 24, 2024
|
@Ricardicus - will update the file shortly. Thanks for all of the helpful comments! |
Tab/space fix - return .PHONY for CI use.
Ricardicus
reviewed
Apr 24, 2024
|
Changes made in #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimmed down the Makefile changes earlier for Windows. Tested with Windows and with Ubuntu 22 (WSL) - no issues. I noticed the Cuda performance has improved by 2x which was cool. Once this is in, then I'll use this to update the CI and we'll have coverage for Windows. Let me know if you see anything problematic. Was thinking we could reorganize this file into 3 discrete sections: OS check, Compiler check and Build. Just a thought...