Reduce consecutive diffmods to one #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was just discussing this project with @jesperronn and my last chance introduced a regression, which i meant to revert. Basically we should undo the ignore tags part, which was never used anywhere. We can either do that now, and rebase your PR, or do it after, if you prefer @troelskn ? |
|
Well. Naturally, I would prefer to have mine merged now, since it's already ready to do so. I'm not sure what exactly |
jesperronn
reviewed
Dec 4, 2017
spec/htmldiff_spec.rb
Outdated
| @@ -59,4 +59,12 @@ class TestDiff | |||
| diff = TestDiff.diff(a, b) | |||
| expect(diff).to eq("<p><del class=\"diffmod\">a</del><ins class=\"diffmod\">ab</ins></p><p><ins class=\"diffins\">c</ins></b>") | |||
| end | |||
|
|
|||
| it "should reduce consecutive matches" do | |||
There was a problem hiding this comment.
Please also make the same test example with reduce_consecutive: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes for a prettier output. I made the feature be opt-in to not break any existing code, but most users would probably benefit from enabling it. I also changed the constructor signature to use named parameters, but retained BC.