Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set background cacscade deletion by default #970

Merged

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Refer to #969 for more details.

Which issue(s) this PR fixes:
Fixes #969

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: now delete resources from member cluster uses "Background" as default delete option.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 16, 2021
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2021
@RainbowMango
Copy link
Member Author

/cc @Garrybest @mrlihanbo

@mrlihanbo
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@Garrybest
Copy link
Member

/lgtm

@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 32189e2 into karmada-io:master Nov 16, 2021
@RainbowMango RainbowMango deleted the pr_set_default_deleteoption branch November 16, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod resource leak when delete jobs
4 participants