Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt the Scheduled condition for binding #838

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

After merge PR #823, there still are some logic use len(binding.Spec.Clusters) == 0 to judge weather binding has been ready to sync. So this pr modify this.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2021
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2021
@XiShanYongYe-Chang
Copy link
Member Author

/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the adapt-scheduled-condition branch from ebec118 to 4dd719f Compare October 20, 2021 01:33
@XiShanYongYe-Chang
Copy link
Member Author

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@dddddai
Copy link
Member

dddddai commented Oct 20, 2021

I guess getTypeFromResourceBindings should also be changed

func (s *Scheduler) getTypeFromResourceBindings(ns, name string) ScheduleType {
resourceBinding, err := s.bindingLister.ResourceBindings(ns).Get(name)
if apierrors.IsNotFound(err) {
return Unknown
}
if len(resourceBinding.Spec.Clusters) == 0 {
return FirstSchedule
}

@XiShanYongYe-Chang
Copy link
Member Author

I guess getTypeFromResourceBindings should also be changed

Thanks, I missed it.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the adapt-scheduled-condition branch from 4dd719f to 8e1e16e Compare October 20, 2021 02:59
@RainbowMango
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit d535f70 into karmada-io:master Oct 21, 2021
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the adapt-scheduled-condition branch October 26, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants