-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt the Scheduled condition for binding #838
adapt the Scheduled condition for binding #838
Conversation
/hold |
ebec118
to
4dd719f
Compare
/hold cancel |
I guess karmada/pkg/scheduler/scheduler.go Lines 808 to 816 in d2af1e1
|
Thanks, I missed it. |
Signed-off-by: changzhen <[email protected]>
4dd719f
to
8e1e16e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: changzhen [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
After merge PR #823, there still are some logic use
len(binding.Spec.Clusters) == 0
to judge weather binding has been ready to sync. So this pr modify this.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: