Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate status no matter if ensured work or not #817

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

dddddai
Copy link
Member

@dddddai dddddai commented Oct 14, 2021

Signed-off-by: dddddai [email protected]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Please refer to #768 (comment)

Which issue(s) this PR fixes:
Fixes #768

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bugfix: fix status stop aggregating after cluster unjoined.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 14, 2021
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2021
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@RainbowMango
Copy link
Member

/approve
Leave lgtm to @XiShanYongYe-Chang .

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XiShanYongYe-Chang
Copy link
Member

Good job.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@karmada-bot karmada-bot merged commit a9250c5 into karmada-io:master Oct 15, 2021
@dddddai dddddai deleted the test branch October 24, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceBinding aggregated status is not updated after unjoinning a target cluster
4 participants