Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce feature gates for the scheduler component #805

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Introduce feature gates for the scheduler component #805

merged 1 commit into from
Nov 5, 2021

Conversation

iawia002
Copy link
Member

@iawia002 iawia002 commented Oct 12, 2021 •
edited
Loading

Signed-off-by: iawia002 [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduce the feature gates package to allow users to control whether to enable/disable some global features, this can also be used in other components in the future.

Which issue(s) this PR fixes:
Fixes #701

Special notes for your reviewer:

I directly removed the --failover flag. I don’t know if we need to ensure compatibility in the current version.

Does this PR introduce a user-facing change?:

Introduce feature gates for the scheduler component.

/cc @RainbowMango

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2021
@iawia002
Copy link
Member Author

iawia002 commented Oct 14, 2021 •
edited
Loading

this can also be used in other components in the future.

To achieve this, I made a few adjustments to make the entire features package easier to use. See commit 59d8f64 for detail.

@RainbowMango
Copy link
Member

That's interesting. I'll look at it later. Thanks!
/assign

@RainbowMango
Copy link
Member

Hi @iawia002 I added this PR to the next meeting agenda, hope we can have a chat there.

@iawia002
Copy link
Member Author

Hi @iawia002 I added this PR to the next meeting agenda, hope we can have a chat there.

Sure, I will be there.

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Oct 28, 2021
Closed
@RainbowMango
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@karmada-bot karmada-bot merged commit 393769e into karmada-io:master Nov 5, 2021
@iawia002 iawia002 deleted the feature-gate branch November 5, 2021 15:27
@iawia002 iawia002 mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add featuregate support
3 participants
@iawia002 @RainbowMango @karmada-bot