Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod constraint in general estimator #777

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

Garrybest
Copy link
Member

@Garrybest Garrybest commented Sep 29, 2021

Signed-off-by: Garrybest [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Max allowed pod number is an invisible constraint when calculating max available replicas in general estimator.
This PR is related to #723.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-scheduler-estimator: The number of pods is also an important reference now when calculating available replicas for the cluster.

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2021
@Garrybest
Copy link
Member Author

/cc @qianjun1993

@qianjun1993
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@RainbowMango
Copy link
Member

LGTM
But you might need to rebase your code as the master just fixed a compile failure.

@RainbowMango
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2021
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit b961a7e into karmada-io:master Oct 2, 2021
@Garrybest Garrybest deleted the pr_pod_estimator branch October 2, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants