-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9] karmadactl init: set default value of imagePullPolicy to IfNotPresent #4988
[1.9] karmadactl init: set default value of imagePullPolicy to IfNotPresent #4988
Conversation
/hold |
Signed-off-by: zhzhuang-zju <[email protected]>
9ceeddf
to
d909f60
Compare
/lgtm |
LGTM as a temporary solution for fix test. (This actually changes the behavior of karmadactl init.) |
Yes. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
refer to #4976 (comment) and #4976 (comment) and #4976 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: