Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9] karmadactl init: set default value of imagePullPolicy to IfNotPresent #4988

Conversation

zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju commented May 27, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
refer to #4976 (comment) and #4976 (comment) and #4976 (comment)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`:  The policy for when to pull a container image now is `IfNotPresent in `init` command.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2024
@RainbowMango
Copy link
Member

/hold
see #4976 (comment) and #4976 (comment)

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
@zhzhuang-zju zhzhuang-zju force-pushed the automated-cherry-pick-of-#4815-upstream-release-1.9 branch from 9ceeddf to d909f60 Compare May 27, 2024 03:45
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2024
@zhzhuang-zju zhzhuang-zju changed the title Automated cherry pick of #4815: add image-pull-policy flag for karmada init cmd karmadactl init: set default value of imagePullPolicy to IfNotPresent May 27, 2024
@zhzhuang-zju zhzhuang-zju changed the title karmadactl init: set default value of imagePullPolicy to IfNotPresent [1.9] karmadactl init: set default value of imagePullPolicy to IfNotPresent May 27, 2024
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@liangyuanpeng
Copy link
Contributor

LGTM as a temporary solution for fix test. (This actually changes the behavior of karmadactl init.)

@RainbowMango
Copy link
Member

LGTM as a temporary solution for fix test. (This actually changes the behavior of karmadactl init.)

Yes.
Given the karmadactl init is an installation tool, it doesn't require so strict compatibility.
I agree with you, it's a tradeoff.

@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@karmada-bot karmada-bot merged commit abbb1df into karmada-io:release-1.9 May 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants