-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support auto bump container images with dependabot. #4932
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4932 +/- ##
==========================================
+ Coverage 53.14% 53.34% +0.19%
==========================================
Files 251 252 +1
Lines 20415 20482 +67
==========================================
+ Hits 10850 10926 +76
+ Misses 8852 8835 -17
- Partials 713 721 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Amazing!
I think letting Dependabot handle these things for both master and release branches would be better. Two more things we should consider about:
|
For simplicity I would choose option 2.2, other idea is welcome . |
OK.
Will see, those solutions sound a little bit heavy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Signed-off-by: Lan Liang <[email protected]>
00db0fa
to
26db029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
support auto bump container images with dependabot, but I'm not sure whether we should treat release branch like this, it's means we need to update release branch from this file when a new release is out.
option2 is only auto bump container image for master and cherry pick the PR of dependabot to release branch if need.
Which issue(s) this PR fixes:
Fixes #4908
Special notes for your reviewer:
Does this PR introduce a user-facing change?: