Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-gen version from v0.13.0 to v0.14.0 #4874

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Apr 26, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR bumps controller-tools and refreshes the generated CRDs.

Which issue(s) this PR fixes:
Fixes #4873

Special notes for your reviewer:
Notable changes of controller-tools:

  • Remove usages of deprecated io/ioutil
  • Add support for empty maps or lists
  • CRD: Respect multiline comments at godocs

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 26, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.08%. Comparing base (c6ccb99) to head (ec3f9cf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4874      +/-   ##
==========================================
+ Coverage   53.06%   53.08%   +0.01%     
==========================================
  Files         251      251              
  Lines       20387    20387              
==========================================
+ Hits        10819    10822       +3     
+ Misses       8855     8852       -3     
  Partials      713      713              
Flag Coverage Δ
unittests 53.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng
Copy link
Contributor

LGTM

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for doing this.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@karmada-bot karmada-bot merged commit 80ee3b2 into karmada-io:master Apr 28, 2024
13 checks passed
@seanlaii seanlaii deleted the bump-controller-gen-version branch August 29, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update controller-gen version from v0.13.0 to v0.14.0
5 participants