-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kubernetes dependencies to v1.27.3 #3730
Bump Kubernetes dependencies to v1.27.3 #3730
Conversation
Hi @lonelyCZ, need your help here.
I'm looking into it, but don't have a clue yet. |
I will look it today! |
I just inspected it, and I found this commit at kubernetes codebase . We can resolve it by implementing this interface. Like here cc7494c The testing result is that |
c016ba3
to
afb1a69
Compare
Thank you so much for working on this issue late into the night! Take care of yourself. |
afb1a69
to
6f4f3b4
Compare
The next breaking change we need to adopt is kubernetes-sigs/controller-runtime#2296 which removed the karmada/pkg/util/restmapper/restmapper.go Line 92 in 9a03a10
References:
|
3a07a1e
to
2d7e2f9
Compare
9977684
to
453fdab
Compare
139af7a
to
2ff237c
Compare
6dfab1f
to
4184b56
Compare
Current blocker is that
edit: Fixed. |
4184b56
to
1150e36
Compare
Hi @ikaven1024 Need your help here. The
|
Update controller-runtime to v0.15.0 Update cluster-api to v1.5.0-rc.0 Update sigs.k8s.io/metrics-server to v0.6.1-0.20230706083104-796fc0f832c1 Update sigs.k8s.io/custom-metrics-apiserver to v1.27.0 Signed-off-by: RainbowMango <[email protected]>
1150e36
to
01e788c
Compare
…ames for core types Adopt breaking change of contriller-runtime PR 2122 Adopt breaking change of contriller-runtime PR 2296 Adopt breaking change of controller-runtime PR 2139 Adopt breaking change of controller-runtime PR 2135 Adopt breaking change of Kubernetes PR 116218 Adopt breaking change of controller-runtime PR 2149 Adopt breaking change of controller-runtime PR 2150 Adopt breaking change of controller-runtime PR 2134 Adopt breaking change of controller-runtime PR 2293 Adopt breaking change of controller-runtime PR 2144 Adopt k8s feature: watch list. PR 115402 Adopt breaking change of Kubernetes PR 117102 Adopt Kubernetes change: disable staticcheck Fix unit tests that failure due to fake-client behavior changes. Signed-off-by: RainbowMango <[email protected]>
Update auto-generated files Signed-off-by: RainbowMango <[email protected]>
01e788c
to
3f5c907
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3730 +/- ##
==========================================
- Coverage 55.18% 54.93% -0.26%
==========================================
Files 227 227
Lines 21671 21676 +5
==========================================
- Hits 11960 11907 -53
- Misses 9074 9130 +56
- Partials 637 639 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Great thanks to @lonelyCZ @ikaven1024 @XiShanYongYe-Chang @jwcesign @zishen @Poor12 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates Kubernetes dependencies to v1.27.3 as well as transitive dependencies and adoption:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: