Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the usage description of --kubeconfig flag #1342

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Feb 8, 2022

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As discussed in #1336 (review), we need to modify the usage description of kubeconfig flag to the correct meaning.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Modify the kubeconfig usage description of the `karmada-controller-manager/karmada-scheduler/karmada-webhook/karmada-aggregated-apiserver` executable file.

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 8, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Modify the kubeconfig usage description of the executable file Modify the kubeconfig flag usage description of the executable file Feb 8, 2022
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

pkg/util/constants.go Outdated Show resolved Hide resolved
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the modify-kubeconfig-description branch 2 times, most recently from 317d8bb to 9b02f14 Compare February 10, 2022 07:33
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the modify-kubeconfig-description branch from 9b02f14 to eeee662 Compare February 10, 2022 08:06
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2022
@RainbowMango
Copy link
Member

/retitle improve the usage description of --kubeconfig flag

@karmada-bot karmada-bot changed the title Modify the kubeconfig flag usage description of the executable file improve the usage description of --kubeconfig flag Feb 10, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave LGTM to @lonelyCZ

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@lonelyCZ
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@karmada-bot karmada-bot merged commit e494bda into karmada-io:master Feb 10, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the modify-kubeconfig-description branch February 27, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants