introduce concurrent flags to controllers

[pigletfly]

Signed-off-by: pigletfly [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:

Make controller reconcile concurrent configurable

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Introduced several flags to specify controller's capacities:
- --concurrent-work-syncs
- --concurrent-namespace-syncs
- --concurrent-resource-template-syncs
- --concurrent-cluster-syncs
- --concurrent-clusterresourcebinding-syncs
- --concurrent-resourcebinding-syncs

`karmada-agent`: Introduced several flags to specify controller's capacities:
- --concurrent-work-syncs
- --concurrent-cluster-syncs

The larger number of these flags means faster controller reconciles, but more CPU (and network) load.

[pigletfly]

if numbers of objects are huge,controller can't proccess them in time.In my case, pp objects get reconciled after serveral minutes.

[pigletfly]

/release-note-none

[pigletfly]

/priority important-soon

[pigletfly]

/cc @RainbowMango @Garrybest

[Garrybest]

Refer to #1260

[Garrybest]

Hi @pigletfly, what about make it easier by using ControllerConfigurationSpec in when NewManager? Like this.

controllerManager, err := controllerruntime.NewManager(config, controllerruntime.Options{
	Scheme:                     gclient.NewSchema(),
	SyncPeriod:                 &opts.ResyncPeriod.Duration,
	LeaderElection:             opts.LeaderElection.LeaderElect,
	LeaderElectionID:           opts.LeaderElection.ResourceName,
	LeaderElectionNamespace:    opts.LeaderElection.ResourceNamespace,
	LeaderElectionResourceLock: opts.LeaderElection.ResourceLock,
	HealthProbeBindAddress:     net.JoinHostPort(opts.BindAddress, strconv.Itoa(opts.SecurePort)),
	LivenessEndpointName:       "/healthz",
	Controller: v1alpha1.ControllerConfigurationSpec{
		GroupKindConcurrency: map[string]int{
			workv1alpha2.SchemeGroupVersion.WithKind("ResourceBinding"): rbConcurrentReconciles,
			workv1alpha2.SchemeGroupVersion.WithKind("ClusterResourceBinding"): crbConcurrentReconciles,
			workv1alpha1.SchemeGroupVersion.WithKind("Work"): workConcurrentReconciles,
			......
		},
	},
})

[pigletfly]

Hi @pigletfly, what about make it easier by using ControllerConfigurationSpec in when NewManager? Like this.

controllerManager, err := controllerruntime.NewManager(config, controllerruntime.Options{
	Scheme:                     gclient.NewSchema(),
	SyncPeriod:                 &opts.ResyncPeriod.Duration,
	LeaderElection:             opts.LeaderElection.LeaderElect,
	LeaderElectionID:           opts.LeaderElection.ResourceName,
	LeaderElectionNamespace:    opts.LeaderElection.ResourceNamespace,
	LeaderElectionResourceLock: opts.LeaderElection.ResourceLock,
	HealthProbeBindAddress:     net.JoinHostPort(opts.BindAddress, strconv.Itoa(opts.SecurePort)),
	LivenessEndpointName:       "/healthz",
	Controller: v1alpha1.ControllerConfigurationSpec{
		GroupKindConcurrency: map[string]int{
			workv1alpha2.SchemeGroupVersion.WithKind("ResourceBinding"): rbConcurrentReconciles,
			workv1alpha2.SchemeGroupVersion.WithKind("ClusterResourceBinding"): crbConcurrentReconciles,
			workv1alpha1.SchemeGroupVersion.WithKind("Work"): workConcurrentReconciles,
			......
		},
	},
})

that's fine with normal controllers (e.g,ResourceBinding) except detector,work,cluster.

[pigletfly]

@Garrybest @RainbowMango PTAL

[Garrybest]

I think you may forget this.

karmada/pkg/detector/detector.go

Line 97 in b5493cc

d.bindingReconcileWorker.Run(1, d.stopCh)

karmada/pkg/controllers/mcs/service_export_controller.go

Line 116 in b5493cc

c.worker.Run(c.WorkerNumber, c.StopChan)

[pigletfly]

I think you may forget this.

karmada/pkg/detector/detector.go

Line 97 in b5493cc

d.bindingReconcileWorker.Run(1, d.stopCh)

karmada/pkg/controllers/mcs/service_export_controller.go

Line 116 in b5493cc

c.worker.Run(c.WorkerNumber, c.StopChan)

good catch.But resourcebinding shares the same flag,we can't redefined in detector.Or we can hack like this flag.Lookup("resourcebinding-workers").Value.(flag.Getter).Get().(int) in detector.And I will send a separate PR to move resourcebinding reconcile all into resourcebinding_controller,then there will be only one flag.

xref #1309

[RainbowMango]

I guess we are good to go now.
@dddddai @Garrybest
Could you please take a look?

[dddddai]

/lgtm

[Garrybest]

Nice work👍
/lgtm

[RainbowMango]

/retitle introduce concurrent flags to controllers

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment