Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documents for installing Karmada in Kind #1240

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add documents for installing Karmada in Kind cluster.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

cc @prodanlabs

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 11, 2022
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2022
@prodanlabs
Copy link
Member

#1232 (comment) Have you encountered this problem?

Copy link
Member Author

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't test that, just focus on installation.

@RainbowMango RainbowMango force-pushed the pr_doc_install_in_kind branch from 93d4a17 to 25b27d4 Compare January 12, 2022 08:11
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2022
Copy link
Member Author

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prodanlabs
I just tested again, and we can install Karmada outside of the Kind cluster.
That's great!

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 12, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit ec4fd77 into karmada-io:master Jan 12, 2022
@RainbowMango RainbowMango deleted the pr_doc_install_in_kind branch January 12, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants