-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmada-scheduler: merge scalescheduling with normal scheduling #1051
Conversation
The PR has been divided into 3 commits.
|
@Garrybest: GitHub didn't allow me to request PR reviews from the following users: gf457832386, BDXGD. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Same idea with #988 (comment). |
cc @dddddai |
f2d6c3a
to
ac0ce60
Compare
As we merged the logic of first schedule and scale schedule, Maybe we do not need retain the cluster with 0 replicas in scheudlue result.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review still on-going.
We are lacking proper abstractions, the code becomes difficult to understand, now. :(
Emmm, that's right, too complicated😵💫. But this PR could help make it better because we merge the two cases. |
Yes, this PR is a relief. |
ac0ce60
to
b2a391f
Compare
Signed-off-by: Garrybest <[email protected]>
Signed-off-by: Garrybest <[email protected]>
b2a391f
to
6463c79
Compare
Signed-off-by: Garrybest <[email protected]>
6463c79
to
4acb5ae
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Now scale scheduling has a particular process without share the same logic with normal scaleduling. Here shows some problems:
Now the two steps have been merged. Actually, the first scheduling is a special kind of
scaling up
. There is no need to separate the two kinds.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: