Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lfx-mentorship]Refactor get command to leverage aggregated API #1329

Closed
RainbowMango opened this issue Jan 28, 2022 · 8 comments
Closed

[lfx-mentorship]Refactor get command to leverage aggregated API #1329

RainbowMango opened this issue Jan 28, 2022 · 8 comments
Assignees
@lonelyCZ
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@RainbowMango
Copy link
Member

What would you like to be added:
Now karmadactl get command retrieves resources by Cluster token stores at Cluster object.
We should refactor it to leverage the Aggregated API, the benefits would be:

  1. Both Push and Pull clusters are supported
  2. Stop using the administrator's credential to access member clusters.

Why is this needed:
@RainbowMango RainbowMango added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 28, 2022
@RainbowMango RainbowMango changed the title Refactor get command to leverage aggregated API [lfx-mentorship]Refactor get command to leverage aggregated API Jan 28, 2022
@ccchenjiahuan
Copy link

@RainbowMango hi, l am interested in this project and want to take this as my lfx project. Are there any pre-requirements before applying, e.g detailed design?

@lonelyCZ
Copy link
Member

lonelyCZ commented Feb 9, 2022

Hi @ccchenjiahuan, sorry, I am working on this function, please look at #1091 #1219 #1343.

@ccchenjiahuan
Copy link

Hi @ccchenjiahuan, sorry, I am working on this function, please look at #1091 #1219 #1343.

@lonelyCZ Thanks for your reminding!
@RainbowMango So are there any available karmada lfx projects to apply for now? Please let me know ahead, thanks!

@RainbowMango
Copy link
Member Author

I've posted 4 projects to LFX. And I will post some ideas to the Google Summer of Code.

If you have any ideas/proposals, please feel free to let me know.

@lonelyCZ lonelyCZ mentioned this issue Mar 12, 2022
Merged
@RainbowMango
Copy link
Member Author

/assign @lonelyCZ

@lonelyCZ lonelyCZ mentioned this issue Mar 23, 2022
Merged
Repository owner moved this from Todo to Done in Karmada Release 1.1 Mar 24, 2022
@XiShanYongYe-Chang
Copy link
Member

Maybe the refactor not be over?

@lonelyCZ
Copy link
Member

Maybe the refactor not be over?

Yes, there are other tasks, for example, performance optimization.

/reopen

@lonelyCZ
Copy link
Member

I seemingly don't have right. Could you please reopen this issue? @RainbowMango

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lonelyCZ lonelyCZ

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Release 1.1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RainbowMango @lonelyCZ @XiShanYongYe-Chang @ccchenjiahuan