Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable karmadactl get to support pull mode. #1091

Closed
lonelyCZ opened this issue Dec 11, 2021 · 3 comments · Fixed by #1575
Closed

Enable karmadactl get to support pull mode. #1091

lonelyCZ opened this issue Dec 11, 2021 · 3 comments · Fixed by #1575
Assignees
@lonelyCZ
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v1.2

Comments

@lonelyCZ
Copy link
Member

What would you like to be added:
If we don't consider that there is only single side network communication from member cluster to karmada control plane. We can enable karmadactl get to support pull mode. There are two way to do this.

  1. Using --cluster-kubeconfig and --cluster-context.
  2. Add access secret of member cluster of pull mode to karmada control plane.

Why is this needed:
This command can be used with the migrate command, we also add a field that can check if the workload are managed by karmada through karmadactl get.
@lonelyCZ lonelyCZ added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2021
@lonelyCZ
Copy link
Member Author

/assign

@RainbowMango
Copy link
Member

I think after #1077, we can get a better solution to achieve this.

@lonelyCZ
Copy link
Member Author

I think after #1077, we can get a better solution to achieve this.

Ok, expecting for it.

@RainbowMango RainbowMango mentioned this issue Jan 21, 2022
Merged
@RainbowMango RainbowMango added this to the v1.1 milestone Jan 21, 2022
@RainbowMango RainbowMango moved this from Todo to In Progress in Karmada Release 1.1 Jan 25, 2022
@lonelyCZ lonelyCZ mentioned this issue Feb 9, 2022
Closed
@RainbowMango RainbowMango modified the milestones: v1.1, v1.2 Mar 9, 2022
@lonelyCZ lonelyCZ mentioned this issue Apr 1, 2022
Merged
Repository owner moved this from In Progress to Done in Karmada Release 1.1 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lonelyCZ lonelyCZ

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Release 1.1
Status: Done
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Implement karmadactl get to support pull mode cluster lonelyCZ/karmada
2 participants
@RainbowMango @lonelyCZ