Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for PhantomJS launcher #40

Closed
wants to merge 7 commits into from
Closed

Quick fix for PhantomJS launcher #40

wants to merge 7 commits into from

Conversation

rdodev
Copy link
Contributor

@rdodev rdodev commented Aug 29, 2012

The id it wanted to append to the temp directory was alphanumeric and due to the truthiness of JS it was trying to cast it to a number, which gave a NaN as a result. Forcibly casting the id toString() solved the issue.

this._tempDir = (env.TMPDIR || env.TMP || env.TEMP || '/tmp') + '/testacular-' + id.toString()

@travisbot
Copy link

This pull request fails (merged 4bcf67f into 18f5fd7).

@vojtajina
Copy link
Contributor

Thanks, merged as 3410c2c

I had to rebase it, so please do:

git reset --hard HEAD~7
git pull upstream master

To make it easier for you, in the future, always create a new branch per feature / fix.

Again, thanks a lot.
Let me know your name and email (don't see it on your github profile), if you wanna be added into contributors...

@vojtajina vojtajina closed this Aug 31, 2012
@rdodev
Copy link
Contributor Author

rdodev commented Aug 31, 2012

@vojtajina I've updated my profile with name and e-mail. Would be great to collaborate as Testacular grows.

@vojtajina
Copy link
Contributor

Added 52dfea7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants