-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted link fixes #3671
Assorted link fixes #3671
Conversation
✅ Build karma 2969 completed (commit 48ad6b8d51 by @XhmikosR) |
✅ Build karma 571 completed (commit 48ad6b8d51 by @XhmikosR) |
✅ Build karma 572 completed (commit 48ad6b8d51 by @XhmikosR) |
|
Thanks for the hints! That being said, the changes don't affect only the docs. How can I combine more than one component? Maybe |
AFAICT only comments are updated, so it should be fine with just docs. Or you can use “docs(core): message” if changes are specific to core. |
There's one link in code too but I don't think it matters a lot. |
✅ Build karma 2970 completed (commit e6eeb58478 by @XhmikosR) |
✅ Build karma 573 completed (commit e6eeb58478 by @XhmikosR) |
✅ Build karma 572 completed (commit e6eeb58478 by @XhmikosR) |
Yes. PS I've amended the last commit to make CI happy. These were changes in the generated files coming from |
✅ Build karma 574 completed (commit 9f4779f7ee by @XhmikosR) |
I'd like to keep those links, though. Can't you just update the dist files? |
✅ Build karma 2971 completed (commit 9f4779f7ee by @XhmikosR) |
✅ Build karma 573 completed (commit 9f4779f7ee by @XhmikosR) |
Unfortunately, we can't do it. Otherwise, we'll have to give up (unnecessarily complicate) a check that bundled client code is up-to-date, which is IMO more important than not having HTTP links. The right fix would be to change the link in https://github.com/webmodules/dom-serialize, get a release, and update, but the package looks abandoned. Not sure if it is worth the trouble. |
Ah, OK, that makes sense. I wasn't aware that was 3rd-party code. All good then :) |
BTW the bots are too chatty 😛 |
You can block them to avoid any notifications. At least that's what I did 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 6.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix redirected npmjs links * change npm to lowercase * use https when possible
There are plenty more redirected links, but I thought I'd make a first PR with these fixes. :)
I could probably squash the first and the third patch into one if you prefer.
PS1. I'd appreciate if someone could update the build assets for me before merging this. I thought this was automated and there are too many npm vulnerabilities AFAICT to even try to do
npm i
.PS2. I'm not familiar with the commitlint conventions, so bear with me here
PS3. I personally prefer using
Number.POSITIVE_INFINITY
for concurrency, but I'm not 100% sure on which Node.js versions is supported. It doesn't change the functionality but it's more explicit.