refactor: inject yargs and minimist instead of optimist #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build karma 2530 failed (commit 5d347eb540 by @akkumar) |
|
❌ Build karma 132 failed (commit 5d347eb540 by @akkumar) |
|
✅ Build karma 131 completed (commit 5d347eb540 by @akkumar) |
|
Any ideas is that a random CI failure or no? @akkumar can you confirm that it's passes locally? |
|
This appears to have already been merged in #3451 |
|
Thanks, looks like this was completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to remove optimist and replace to yargs.
Code - untested.
Would be useful to get somebody review changes to cli.js and cli.spec.js specifically.
Related issues #2472 and #2473 and #3447