Add tests for ES2015 module support #3072
Conversation
- Add support for ES modules via `esModule` property in file config object
`esModule: true` is now `type: 'module'`. Test updated to reflect that.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
| FirefoxWithModules: { | ||
| base: 'Firefox', | ||
| prefs: { | ||
| 'dom.moduleScripts.enabled': true |
There was a problem hiding this comment.
Firefox 60+ should support this out of the box now.
|
Something is wrong with CLA |
|
I verified that @wesleycho is ok with this. I will close and reopen to trigger CI. |
PR is intended to check build status of #2834. This is the same one but rebased off the current HEAD.