refactor: refactor lib/reporter.js #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
suggested changes
May 28, 2018
lib/reporter.js
Outdated
|
|
||
| return function (input, indentation) { | ||
| indentation = _.isString(indentation) ? indentation : '' | ||
| indentation = helper.isString(indentation) ? indentation : '' |
There was a problem hiding this comment.
Rather than introduce helper just for this one case while keeping lodash for the other cases, I'd rather consistently use one or the other.
lib/reporter.js
Outdated
| return cache.get(sourceMap) | ||
| } | ||
|
|
||
| function formatFullPath (path, line, column) { |
There was a problem hiding this comment.
Maybe "formatPathMapping"?
lib/reporter.js
Outdated
|
|
||
| // When no column is given and we default to 0, it doesn't make sense to only search for smaller | ||
| // or equal columns in the sourcemap, let's search for equal or greater columns. |
There was a problem hiding this comment.
I think this comment is helpful.
lib/reporter.js
Outdated
| .originalPositionFor({line: line, column: (column || 0), bias: bias}) | ||
|
|
||
| // Source maps often only have a local file name, resolve to turn into a full path if | ||
| // the path is not absolute yet. |
johnjbarton
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.