fix(reporter): Fix #2930 causing error stack not to be parsed correctly #2932
Conversation
|
@lusarz You have approved my changes, but there are a lot of unit tests failing in my push request and I guess i got it wrong. Did you already review the changes and problems? |
|
@doberkofler Seems like this pull request solve problem, don't know why these unit tests fails - I'll try to figure it out. |
|
@lusarz I noticed the failing unit tests but because most of them seem to be related to the the changes in 2.0, I did not feel as if I should just change them to “my” new behavior. |
lib/reporter.js
Outdated
| @@ -9,7 +9,7 @@ var baseReporterDecoratorFactory = require('./reporters/base').decoratorFactory | |||
|
|
|||
| var createErrorFormatter = function (config, emitter, SourceMapConsumer) { | |||
| var basePath = config.basePath | |||
| var urlRoot = config.urlRoot || '' | |||
| var urlRoot = config.urlRoot !== '/' ? config.urlRoot : '' | |||
There was a problem hiding this comment.
@doberkofler
What about:
var urlRoot = config.urlRoot === '/' ? '' : (config.urlRoot || '')
|
@lusarz Looks good to me. Just committed it to my fork to do some testing. |
|
@doberkofler Which seems to be related with format of commit message. |
|
@lusarz I have changed the commit message and the Travis build now passed. |
|
@doberkofler Seems that no authorized person has time to look at this :( |
|
Since this pr is merged, appveyor build should works. |
|
@dignifiedquire I've added a unit test |
|
Thank you |
|
@dignifiedquire Can I please for release into npm with this pull request? |
Fixed a problem when config.urlRoot is set to '/' causing the error stack not to be parsed correctly and therefore source maps are not used.