Prep for 2.0

[dignifiedquire]

No description provided.

[dignifiedquire]

Need to update the cucumber step defs to fix the tests

[dignifiedquire]

Need to figure out why node 4 and 6 are unhappy

[johnjbarton]

Looks like you need to prevent coffeescript 2.x.
https://github.com/karma-runner/karma/blob/master/package.json#L366
It requires node 6 or higher.
https://github.com/jashkenas/coffeescript/blob/master/package.json

[EzraBrooks]

Did you intend to add a Yarn lockfile? The project currently includes neither a yarn.lock nor a package-lock.json. Will 2.0 be taking a stance on which package manager to use?

[dignifiedquire]

@EzraBrooks I have certain opinions on the matter, but I am not yet sure if it makes sense to add them to karma.

[dignifiedquire]

@johnjbarton interesting, I guess this is only a devdependency so it should be fine to stay on the 1.x branch for now

[EzraBrooks]

Would it be useful for the project to adopt TypeScript's type-checking as part of the lint stage? Just by enabling ts-check on some of the files in the project, there's a lot of ambiguous typing that becomes very obvious. Since you can use the type checking without converting your code to TypeScript, I thought I'd suggest it.

[dignifiedquire]

@EzraBrooks I like the idea, but lets make a separate pr/issue about it.

[dignifiedquire]

This should be ready

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.