Try fixing IE #1818
Try fixing IE #1818
Conversation
| var parser = new DOMParser() | ||
| var doc = parser.parseFromString('<test></test>', 'application/xml') | ||
| expect(stringify(doc)).to.be.eql('<test></test>') | ||
| if (DOMParser) { |
There was a problem hiding this comment.
This will throw if DOMParser is not defined so this check doesn't work. You need to check for typeof being !== 'undefined'.
|
Thanks @mgol! any ideas on why IE 6 completely refuses to connect? |
|
It seems mocha is broken in IE<9? Could you try to update it? Also, it seems they still support IE8 but I'm not sure if they care about IE 6 & 7... What can we do if that's the case? |
|
@mgol hmm, I will update and we will have to see, I'm already including polyfills for older browsers so that might be enough to get things working with mocha. But I expect to see a big drop in library support for IE 6 - 9 now that Microsoft officially dropped them all from their support list. |
Probable but considering that Angular 1 & 2 & Ember still support IE 9, at least IE 9+ will be necessary to support by Karma for some time. Unfortunately, test runners need to be a little more conservative in dropping older browsers than libraries/frameworks that are using them. :) |
Yeah I know, that's why I'm trying to fix this. Just saying that libraries like mocha might not bother to do so. |
|
FWIW Vista is IE9 and isn't EoL until 2017 |
|
This is a little OT but I've made a table compiled from https://support.microsoft.com/en-us/lifecycle#gp/Microsoft-Internet-Explorer & https://support.microsoft.com/en-us/gp/lifeselectindex: Desktop:
Others:
* Beginning January 10, 2017, only Internet Explorer 11 will be supported on Windows Thin PC. In order to continue to receive Internet Explorer 8 updates after January 12, 2016, please contact your Microsoft Account Team. |
|
thanks @mgol so the only one that is fully unsupported right now is IE 6 as far as I understand. If I can get these tests to pass we should be back with support for 7 and above would that be enough for your use cases? |
|
@dignifiedquire Sizzle (jQuery selector engine) still supports IE 6 but we'll be dropping at least this version soon so if we made Karma work in IE 7+ we'd be happy. :) |
|
@mgol I have things passing in IE7 on my local VM saucelabs is still a bit whiny but we'll get there, mind taking this for a spin? |
This allows to pass this option to socket.io which is needed to support IE7-9.
No description provided.