Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace fs with graceful-fs #1726

Closed
wants to merge 1 commit into from

Conversation

marcin992
Copy link

Karma sometimes exceeds the limit of open files in OS. Using of graceful-fs solves the problem.

Closes #544

Karma sometimes exceeds the limit of open files in OS. Using of graceful-fs solves the problem.

closes karma-runner#544
@GitCop
Copy link

GitCop commented Nov 25, 2015

There were the following issues with your Pull Request

  • Commit: 126a74c
    • Your commit message body contains a line that is longer than 80 characters
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@dignifiedquire
Copy link
Member

Thanks a lot for this, this does make sense. Could you please make sure the testsuite is updated so the tests are passing please?

@marcin992
Copy link
Author

Sure, I'll try to fix it soon.

@dignifiedquire
Copy link
Member

@marcin992 ping

@testower
Copy link
Contributor

I took the liberty to go over the tests and submitted another PR here: #1807

@dignifiedquire
Copy link
Member

Fixed in #1807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants