Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope): Pass CLI arguments to karma.config.js. Closes #1561 #1574

Merged
merged 1 commit into from
Sep 9, 2015
Merged

feat(scope): Pass CLI arguments to karma.config.js. Closes #1561 #1574

merged 1 commit into from
Sep 9, 2015

Conversation

danielsiwiec
Copy link
Contributor

Set up config object with CLI arguments, before passing it to karma config

@dignifiedquire
Copy link
Member

Thanks, this looks good, just one thing could you reformat your commit message to

feat(config): Pass CLI arguments to `karma.config.js`. 

Closes #1561

@danielsiwiec
Copy link
Contributor Author

Done

@GitCop
Copy link

GitCop commented Sep 9, 2015

There were the following issues with your Pull Request

  • Commit: eb03db6
    • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Commit: e410911
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

@danielsiwiec
Copy link
Contributor Author

@dignifiedquire Any idea what that AppVeyor failure means?

@scottohara
Copy link

@danielsiwiec According to the Travis logs, it appears to be failing some eslint checks:

test/unit/config.spec.js
42:33 error Requires a space after "{" block-spacing
42:77 error Requires a space before "}" block-spacing
148:70 error Block must not be padded by blank lines padded-blocks

@scottohara
Copy link

Looking at the history of the AppVeyor build, it doesn't seem like it has ever passed?

@danielsiwiec
Copy link
Contributor Author

@scottohara Yeah, I just noticed that and just fixed it. I was puzzled by the AppVeyor failure though:

Specify a project or solution file. The directory does not contain a project or solution file.

Any idea what it means?

@dignifiedquire
Copy link
Member

@danielsiwiec Apvoyer is not properly set up, still working on that, that's why it's failing.

Everything else looks good now, thanks :octocat:

dignifiedquire added a commit that referenced this pull request Sep 9, 2015
…config

feat(scope): Pass CLI arguments to karma.config.js. Closes #1561
@dignifiedquire dignifiedquire merged commit 84fdf42 into karma-runner:master Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants