-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scope): Pass CLI arguments to karma.config.js. Closes #1561 #1574
feat(scope): Pass CLI arguments to karma.config.js. Closes #1561 #1574
Conversation
Thanks, this looks good, just one thing could you reformat your commit message to
|
Done |
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
CLAs look good, thanks! |
@dignifiedquire Any idea what that AppVeyor failure means? |
@danielsiwiec According to the Travis logs, it appears to be failing some eslint checks: test/unit/config.spec.js |
Looking at the history of the AppVeyor build, it doesn't seem like it has ever passed? |
@scottohara Yeah, I just noticed that and just fixed it. I was puzzled by the AppVeyor failure though:
Any idea what it means? |
@danielsiwiec Apvoyer is not properly set up, still working on that, that's why it's failing. Everything else looks good now, thanks |
…config feat(scope): Pass CLI arguments to karma.config.js. Closes #1561
Set up config object with CLI arguments, before passing it to karma config