Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include karma bin in package.json #1322

Closed
wants to merge 1 commit into from

Conversation

dazld
Copy link

@dazld dazld commented Feb 23, 2015

No description provided.

@pkozlowski-opensource
Copy link
Member

@dazld why? Didn't karma-cli work for you?

@dazld
Copy link
Author

dazld commented Feb 23, 2015

hey, when you run npm test, for example, then npm automatically includes the .bin folder in its path for the script which is being run. this means you don't need either a global install of karma, nor do you have to reference the full path to the bin, and can do stuff like..

..
"scripts": {
    "test": "karma start"
  },
..

etc.

@dazld
Copy link
Author

dazld commented Feb 23, 2015

does that make sense..? I know it's a simple change.

@maksimr
Copy link
Contributor

maksimr commented Feb 23, 2015

@dazld you can install karma-cli locally to the project and then you example above will work.

Related issue

@maksimr maksimr closed this Feb 23, 2015
@dazld
Copy link
Author

dazld commented Feb 23, 2015

got it, thanks.

@koba04 koba04 mentioned this pull request Mar 16, 2015
@peter-mouland
Copy link

I was also going to do this PR. Is there a reason why you want the extra step of having to install another dependency rather than just putting the path in to the package.json?

@peter-mouland peter-mouland mentioned this pull request Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants