Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure createPreprocessor throws file err if given #1143

Merged
merged 1 commit into from
Aug 26, 2014

Conversation

keithamus
Copy link
Contributor

Never swallow errors!

@doodlemoonch
Copy link

+1

@maksimr
Copy link
Contributor

maksimr commented Aug 21, 2014

@keithamus Thanks!

Can you fix 'jshint' error?

if (err) {
 throw err;
}

@keithamus
Copy link
Contributor Author

Done hopefully - I'm only using the github editor, not my local editor so fingers crossed 😉

@maksimr
Copy link
Contributor

maksimr commented Aug 22, 2014

Awesome!!
It remains only to change the commit message follow convention.
In your case something like:

fix(preprocessor): Throw error if can't open file (example)

Thank you for your patience :)

@keithamus
Copy link
Contributor Author

@maksimr Done and done.

@maksimr
Copy link
Contributor

maksimr commented Aug 22, 2014

LGTM

@keithamus
Copy link
Contributor Author

I can has merge?

@aymericbeaumet
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants