-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headless Chrome instances is reported as Safari 0.0.0 #2603
Comments
I am seeing the same thing, but I get additional output. That says "executed 0 out of 0 disconnected". I am not sure if this is because I am running Chrome headless or something other issue due to my Karma configuration. |
@madCoder24 I think that's related to another part of your config. The above config works just fine for me. |
Yep, the user agent differs. Regular Chrome:
Headless Chrome:
|
Although Headless Chrome is just a `--headless` flag for Chrome, the user-agent is different, so we can treat it as a special browser. This flag is only available on Linux for now, and the UA has no version included. Related with: karma-runner/karma#2603
Thanks for checking the UA @remcohaszing. Pull request opened upstream to fix this: ua-parser/uap-core#228 |
@remcohaszing the useragent package has now updated the regexps from uap-core (see here) in version |
* correct call to build docker image * Change nodejs server to current LTS release replace PhantomJS with Chrome because PhantomJS is no longer maintained https://groups.google.com/forum/\#!msg/phantomjs/9aI5d-LDuNE/MpCM_wACAQAJ * switch to Chrome-Headless in karma config inspired by: karma-runner/karma#2603 * add package.json ton install dependencies * add package.json ton install dependencies * Revert "add package.json ton install dependencies" This reverts commit 4fdd89f. * add missing package.json * change PhantomJS to Chromium in README.md
@rogeriopvl This issue is back in version 3.0.0 of karma, but now it's detecting |
@Licen-it thanks for reporting. Will have a look ASAP. |
Oh FYI i also noticed it's not detecting Linux version (i was detecting my mac version, but running the tests with jenkins on linux it wasn't) |
Most of this was copied from karma-runner/karma-chrome-launcher#107
Expected behaviour
Google Chrome headless should be reported as Google Chrome.
Actual behaviour
When Google Chrome is configured to run in headless mode, Karma reports it as Safari 0.0.0.
Environment Details
karma --version
): Karma version: 1.5.0google-chrome --version
): Google Chrome 57.0.2987.98karma.config.js
fileSteps to reproduce the behaviour
Just run Karma and view any output where the browser name and version are visible.
The text was updated successfully, but these errors were encountered: