-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL_REGEXP in lib/reporter.js does not match karma-browserify output #1495
Closed
brianmhunt opened this issue
Jul 15, 2015
· 3 comments
· May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed
URL_REGEXP in lib/reporter.js does not match karma-browserify output #1495
brianmhunt opened this issue
Jul 15, 2015
· 3 comments
· May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
Comments
Here's a minimum working example: |
Thanks @brianmhunt for the investigation, I'm happy with your suggested fix. Are you up for a PR? |
Awesome, thanks @dignifiedquire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #1097, the
URL_REGEXP
inkarma/lib/reporter.js
fails for karma-browserify. Karma-browserify spits out urls like this:Whereas the expression,
clearly does not match the output. A simple fix that I have tested is to remove the protocol, like this:
I will cross-post an issue with karma-browserify, as the fix may be preferable on their end.
The text was updated successfully, but these errors were encountered: