List of patterns to preprocess are saved in a closure too early #1340
Comments
andersekdahl
added a commit
to andersekdahl/karma
that referenced
this issue
Mar 7, 2015
Don't lookup the list of patterns of files to preprocess until the preprocessor is called. This because patterns might be added after the preprocessor is created, and those will be missed if the patterns are looked up too early. Closes karma-runner#1340
andersekdahl
added a commit
to andersekdahl/karma-common-js
that referenced
this issue
Mar 7, 2015
Don't expose Buffer by replacing use with a require call, but expose Buffer and process as real globals instead, since they are globals in Node.js. Note that this depends on these issues to be fixed: karma-runner/karma#1340 alexgorbatchev/node-browser-builtins#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the config value for which files to preprocess are saved in a closure when a preprocessor is created. Which means that if a pattern is removed or added after the preprocessor is created, the new pattern is missed because the patterns were saved in a closure.
This is an issue when you're creating a plugin and you want to add a file that you also want to preprocess. That is, in your framework factory function, you add an entry to
config.filesand add an entry toconfig.preprocessorsfor that file. Because of this bug, the preprocessor is never run for the added file.The text was updated successfully, but these errors were encountered: