Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop karma as a peerDependency. #94

Merged
merged 1 commit into from
Jun 9, 2015

Conversation

dignifiedquire
Copy link
Member

For discussion and reasoning see
karma-runner/integration-tests#5.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@maksimr
Copy link
Contributor

maksimr commented Jun 9, 2015

LGTM

dignifiedquire added a commit that referenced this pull request Jun 9, 2015
fix: Drop karma as a peerDependency.
@dignifiedquire dignifiedquire merged commit 7960b84 into karma-runner:master Jun 9, 2015
@dignifiedquire dignifiedquire deleted the rm-peer branch June 9, 2015 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants