feat(adapter): do not filter out karma/jasmine frames from stack if the stack consists entirely of said frames #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjh
force-pushed
the
stack-trace-fix
branch
5 times, most recently
from
65f9cc3 to
63b0070
Compare
…he stack consists entirely of said frames
|
@matthewjh Thanks! |
maksimr
added a commit
that referenced
this pull request
May 12, 2015
feat(adapter): do not filter out karma/jasmine frames from stack if the stack consists entirely of said frames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
If an error is thrown from within karma or jasmine during the running of a test, and this stack trace only contains karma- or jasmine-related entries, then debugging the error can be difficult because an empty stack trace will be logged to the console.
This PR changes the stack entry filtering such that entries from within karma or jasmine will be considered 'relevant' if these are the only frames in the stack, thereby preventing a scenario where an empty stack trace will be served up.